Skip to content

Applied catbuffer generator on aggregate #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from Dec 23, 2019
Merged

Applied catbuffer generator on aggregate #394

merged 27 commits into from Dec 23, 2019

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Dec 20, 2019 •
edited
Loading

Re-applied Typescript Generator

  • Fixed bugs in Typescript generator on AggregateTransaction and receipt builders
  • InnerTransactions in Aggregate is now using EmbeddedTransactionBuilder[] instead of Uint8Array
  • Same on Cosignatures
  • Applied catbuffer on some of the receipts. (buffer schema misses receipt types and resolution statement, see https://github.com/nemtech/catbuffer/issues/18)

Fixed #393 & #395

@rg911 rg911 requested review from evias and fboucquez December 20, 2019 21:38
@rg911 rg911 changed the title Fixed #393 applied catbuffer generator on aggregate Applied catbuffer generator on aggregate Dec 22, 2019
rg911 added 18 commits December 22, 2019 15:00
@rg911
Merge branch 'master' into task/g390_max_fee
250b5c2
@rg911
Merge branch 'master' into task/g393_reapply_catbuffer
38ba4d6
@rg911
Moved object assgin to a static method in MappingDto
6d8c421
@rg911
Fixed #390 Spread operator does not assign super class methods
4c656b2
@rg911
Moved object assgin to a static method in MappingDto
a21ba91
@rg911
Merge branch 'task/g390_max_fee' of github.com:NEMStudios/nem2-sdk-ty…
d65d9eb 
…pescript-javascript into task/g390_max_fee
@rg911
Fixed #393 applied catbuffer generator on aggregate
fc8410b
@rg911
Fixed missing semicolon
62629a0
@rg911
Applied catbuffer on receipt
127124d
@rg911
Merge branch 'task/g393_reapply_catbuffer' of github.com:NEMStudios/n…
0d06c22 
…em2-sdk-typescript-javascript into task/g393_reapply_catbuffer
@rg911
Fixed semicolom in import
57ac6c3
@rg911
Merge pull request #391 from NEMStudios/task/g390_max_fee
7867c9f 
Fixed #390 Spread operator does not assign super class methods
@rg911
Fixed #393 applied catbuffer generator on aggregate
ab5a537
@rg911
Fixed missing semicolon
fc99749
@rg911
Applied catbuffer on receipt
04831f8
@rg911
Fixed semicolom in import
84e5f6c
@rg911
Merge branch 'task/g393_reapply_catbuffer' of github.com:NEMStudios/n…
01370fd 
…em2-sdk-typescript-javascript into task/g393_reapply_catbuffer
@rg911
Removed redundant switch case
70f3ab9
@fboucquez
Copy link
Contributor

I'm approving this PR but there are a few improvements to the catbuffer-generator that will affect the SDK. Issues:

@rg911 rg911 merged commit e9ed91c into symbol:master Dec 23, 2019
@fboucquez fboucquez deleted the task/g393_reapply_catbuffer branch April 13, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evias evias Awaiting requested review from evias

1 more reviewer

@fboucquez fboucquez fboucquez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-apply catbuffer generated code with Aggregate fix

2 participants

@rg911 @fboucquez